fix(bw): multiple issues with menu navigation for 9X type radios #4884
Conversation
pfeerick
changed the title
| evt == EVT_KEY_FIRST(KEY_MINUS) || evt == EVT_KEY_REPT(KEY_MINUS) || | ||
| evt == EVT_ROTARY_RIGHT; | ||
| } | ||
|
|
||
| inline bool IS_PREVIOUS_EVENT(event_t evt) | ||
| { | ||
| return evt == EVT_KEY_FIRST(KEY_UP) || evt == EVT_KEY_REPT(KEY_UP) || | ||
| return evt == EVT_KEY_FIRST(KEY_LEFT) || evt == EVT_KEY_REPT(KEY_LEFT) || |
There was a problem hiding this comment.
Actually, why did you change this? As up/down was correct for popup menu navigation on the t-lite (and also the LR3pro I think). Hence #4917, although depending on the reason it may need to remove this change.
There was a problem hiding this comment.
To fix the left right scrolling on the SF/GF page for 9x nav - I fixed this first and meant to come back and check that it did not affect other things (which it clearly did). Thanks for picking it up - the fix in 4917 looks better.
There was a problem hiding this comment.
Yeah, I thought that might be the case when digging a bit deeper... I suspect it is has been broken somewhere else, but that should hopefully do for now to make most all the use cases work. 🤞 Will need revisiting in the future though as the popup menus should't be responding to sideways keys, hence the real 🐛 is somewhere else 🤪
Co-authored-by: philmoz <philmoz@users.noreply.github.com>
From 2.10 the menu navigation on 9X style radios (T-Lite, T12 and LR3Pro) does not work correctly.
Issues:
Fixing the above issues caused other issues requiring more fixes (Model select page was one row short and FM edit page was missing G9 entry).